~williamvds/microlator: Compare to 0 for Carry in BIT

324c5aeabcb76c6041dc7dd5dcf88050f1c94379 — williamvds 3 years ago e663166

Compare to 0 for Carry in BIT

Instead of casting to bool and negating. A comparison is much clearer.

patch browse .tar.gz

1 files changed, 1 insertions(+), 1 deletions(-)

M src/cpu.cpp

M src/cpu.cpp => src/cpu.cpp +1 -1

@@ 345,7 345,7 @@ constexpr void CPU::oBEQ(ValueStore target) noexcept {
 
 constexpr void CPU::oBIT(ValueStore address) noexcept {
 	const auto input = address.read();
-	flags.set(F::Zero, !toBool(input & accumulator));
+	flags.set(F::Zero, (input & accumulator) == 0U);
 	flags.set(F::Overflow, getBit(6, input));
 	flags.set(F::Negative, isNegative(input));
 }