~sircmpwn/openring: Check for empty feed title

28dc22a0ff77b5d961c11efddc50ff2b8cd663e2 — sourque 3 years ago e566294 1.0.0

Check for empty feed title

For feeds with no title, openring places a link with no clickable
text on the byline ("via ..."). Instead, we replace the empty title
with a sensible substitute (URL.Host).

Additionally, fix an unhandled error.

patch browse .tar.gz

1 files changed, 5 insertions(+), 1 deletions(-)

M openring.go

M openring.go => openring.go +5 -1

@@ 107,6 107,10 @@ func main() {
 			log.Printf("Error fetching %s: %s", source.String(), err.Error())
 			continue
 		}
+		if feed.Title == "" {
+			log.Printf("Warning: feed from %s has no title", source.Host)
+			feed.Title = source.Host
+		}
 		feeds = append(feeds, feed)
 		log.Printf("Fetched %s", feed.Title)
 	}


@@ 142,7 146,7 @@ func main() {
 			summary := runewidth.Truncate(
 				policy.Sanitize(raw_summary), *summaryLen, "…")
 
-			itemLink, _ := url.Parse(item.Link)
+			itemLink, err := url.Parse(item.Link)
 			if err != nil {
 				log.Fatal("failed parsing article URL of the feed item")
 			}