~shulhan/asciidoctor-go

b8fdcc2be2fcae1bfd3dd62b8bc2d4abe75e78d0 — Shulhan 3 months ago 741463b
all: rename struct "AttributeEntry" to "DocumentAttribute"

This is to make the struct is clear that it represent the document
attribute.
3 files changed, 13 insertions(+), 13 deletions(-)

M document.go
R attribute_entry.go => document_attribute.go
M parser_test.go
M document.go => document.go +2 -2
@@ 31,7 31,7 @@ type Document struct {
	preamble *element
	content  *element

	Attributes AttributeEntry
	Attributes DocumentAttribute
	sectnums   *sectionCounters

	// titleID is the reverse of anchors, it contains mapping of title and


@@ 76,7 76,7 @@ func newDocument() (doc *Document) {
		TOCLevel:   defTOCLevel,
		tocClasses: attributeClass{},
		tocTitle:   defTOCTitle,
		Attributes: newAttributeEntry(),
		Attributes: newDocumentAttribute(),
		classes:    attributeClass{},
		anchors:    make(map[string]*anchor),
		titleID:    make(map[string]string),

R attribute_entry.go => document_attribute.go +6 -6
@@ 5,12 5,12 @@ package asciidoctor

import "strings"

// AttributeEntry contains the mapping of global attribute keys in the headers
// with its value.
type AttributeEntry map[string]string
// DocumentAttribute contains the mapping of global attribute keys in the
// headers with its value.
type DocumentAttribute map[string]string

func newAttributeEntry() AttributeEntry {
	return AttributeEntry{
func newDocumentAttribute() DocumentAttribute {
	return DocumentAttribute{
		MetaNameGenerator:       `asciidoctor-go ` + Version,
		metaNameLastUpdateLabel: `Last updated`,
		metaNameLastUpdateValue: ``,


@@ 21,7 21,7 @@ func newAttributeEntry() AttributeEntry {
	}
}

func (entry *AttributeEntry) apply(key, val string) {
func (entry *DocumentAttribute) apply(key, val string) {
	switch {
	case key[0] == '!':
		delete(*entry, strings.TrimSpace(key[1:]))

M parser_test.go => parser_test.go +5 -5
@@ 19,7 19,7 @@ func TestGenerateID(t *testing.T) {
	var cases = []testCase{{
		desc: `Without idprefix and idseparator`,
		doc: &Document{
			Attributes: AttributeEntry{},
			Attributes: DocumentAttribute{},
		},
		inputExp: map[string]string{
			`a b c`:  `a_b_c`,


@@ 28,7 28,7 @@ func TestGenerateID(t *testing.T) {
	}, {
		desc: `With idprefix`,
		doc: &Document{
			Attributes: AttributeEntry{
			Attributes: DocumentAttribute{
				metaNameIDPrefix: `123`,
			},
		},


@@ 39,7 39,7 @@ func TestGenerateID(t *testing.T) {
	}, {
		desc: `With empty idseparator`,
		doc: &Document{
			Attributes: AttributeEntry{
			Attributes: DocumentAttribute{
				metaNameIDSeparator: ``,
			},
		},


@@ 50,7 50,7 @@ func TestGenerateID(t *testing.T) {
	}, {
		desc: `With idseparator`,
		doc: &Document{
			Attributes: AttributeEntry{
			Attributes: DocumentAttribute{
				metaNameIDSeparator: `-`,
			},
		},


@@ 61,7 61,7 @@ func TestGenerateID(t *testing.T) {
	}, {
		desc: `With idprefix and idseparator`,
		doc: &Document{
			Attributes: AttributeEntry{
			Attributes: DocumentAttribute{
				metaNameIDPrefix:    `id_`,
				metaNameIDSeparator: `-`,
			},