ref: 8a516e9e064619dcb3d84499b66e1562546be918 xmpp/starttls.go -rw-r--r-- 3.4 KiB
xmpp: make STARTTLS always required

TLS (or at the time, SSL) may have been an optional feature in the past,
but it's not anymore. These days it's far more likely that a server will
always want to require TLS in some form, so giving the user the ability
to turn it off just means we're giving users who won't understand the
consequences of their actions a knob to twiddle. In the very rare case
that a user actually *does* need STARTTLS to be an optional stream
feature, I don't think it's something we should support. For this rare
use case, they'll have to take the maintenance burden on themselves by
copy/pasting the StartTLS feature code and tweaking it for their needs.

Fixes #50

Signed-off-by: Sam Whited <sam@samwhited.com>
all: update BUG comments

Remove inaccurate BUG comments and update existing ones to contain a
link to their relavant issue so that they get removed if the issue is

Signed-off-by: Sam Whited <sam@samwhited.com>
all: add new API to make reading tokens safer
Revert "all: new session XML read/write API"

This reverts commit 5265955b9c79963ea0c1b9f392db0e56b6a242a8.
all: new session XML read/write API
all: improve documentation
xmpp: minor documentation fixes and tweaks

[ci skip]
all: update copyright message

[ci skip]
all: rewrap copyright comments/use xml.TokenReader
all: use xmlstream.TokenWriter in features

Fixes #39
xmpp: remove unused starttls error

[ci skip]
all: always wrap ReadWriter's in a Conn
xmpp: remove TLSConfig from Config

See #38
all: make *Session an xml.TokenReader

This is less efficient than returning one when wraping it in an
xml.Decoder because the underlying decoder cannot be used, but it makes
the API nicer to use.
all: use xmlstream.TokenReader

See #14
stream: rename streamerror package to stream
internal/ns: move ns package to internal/ns
Remove unexported identifiers from features

Fixes #13
Session should not close the underlying Conn
Make session addr functions return JID
More session cleanup