~niklaseklund/egerrit

ab512fece41b95cbec8f48bf1883290a6c95e727 — Niklas Eklund a month ago 1ed0335
Update docstrings for review commands
1 files changed, 30 insertions(+), 8 deletions(-)

M egerrit-review.el
M egerrit-review.el => egerrit-review.el +30 -8
@@ 78,7 78,10 @@ Optionally send a REVIEW-MESSAGE."

;;;###autoload
(defun egerrit-author-review-change (change)
  "Review CHANGE as an author."
  "Review CHANGE as an author.

Optionally when using a prefix argument `egerrit' will let the user
select a specific revision."
  (interactive
   (list (tabulated-list-get-id)))
  (let ((egerrit--switch-branch nil)


@@ 87,7 90,14 @@ Optionally send a REVIEW-MESSAGE."

;;;###autoload
(defun egerrit-author-review-partial-change (change)
  "Review a partial CHANGE as an author."
  "Review a partial CHANGE as an author.

A partial change consists of the difference between the latest
revision and an arbitrary revision.  This differs from the ordinary
review which compares the latest revision with the base.

Optionally when using a prefix argument `egerrit' will let the user
select a specific revision other than the latest"
  (interactive
   (list (tabulated-list-get-id)))
  (let ((egerrit--switch-branch nil)


@@ 96,7 106,10 @@ Optionally send a REVIEW-MESSAGE."

;;;###autoload
(defun egerrit-review-change (change)
  "Review CHANGE."
  "Review CHANGE as a reviewer.

Optionally when using a prefix argument `egerrit' will let the user
select a specific revision."
  (interactive
   (list (tabulated-list-get-id)))
  (when (egerrit-change-p change)


@@ 113,7 126,14 @@ Optionally send a REVIEW-MESSAGE."

;;;###autoload
(defun egerrit-review-partial-change (change)
  "Review a partial CHANGE."
  "Review a partial CHANGE as a reviewer.

A partial change consists of the difference between the latest
revision and an arbitrary revision.  This differs from the ordinary
review which compares the latest revision with the base.

Optionally when using a prefix argument `egerrit' will let the user
select a specific revision other than the latest"
  (interactive
   (list (tabulated-list-get-id)))
  (when (egerrit-change-p change)


@@ 122,10 142,12 @@ Optionally send a REVIEW-MESSAGE."
           (base-revision
            (egerrit-select-revision egerrit--current-change (egerrit--change-revisions egerrit--current-change) "Select base revision: "))
           (revision
            (egerrit-select-revision egerrit--current-change
                                     (seq-filter (lambda (it)
                                                   (> (egerrit--revision-number it) (egerrit--revision-number base-revision)))
                                                 (egerrit--change-revisions egerrit--current-change)))))
            (if current-prefix-arg
                (egerrit-select-revision egerrit--current-change
                                         (seq-filter (lambda (it)
                                                       (> (egerrit--revision-number it) (egerrit--revision-number base-revision)))
                                                     (egerrit--change-revisions egerrit--current-change)))
              (seq-first (seq-reverse (egerrit--change-revisions egerrit--current-change))))))
      (if (and (eq egerrit--mode 'reviewer)
               (not (egerrit--clean-git-repository change)))
          (message "The git repository can't be dirty when engaging in a review")