automatic post-release commit for mutt-1.13.3
Update UPDATING file for 1.13.3 release.
Update copyrights to 2020.
Fix crash when polling a closed ssl connection.
Commit 8353407c enabled checking for buffered OpenSSL/GnuTLS data when
polling, but neglected to check if the connection was already closed.
This can be triggered during imap_logout() if the connection write of
"LOGOUT" fails and closes the connection, before the poll. It's a bit
tricky to trigger because imap_logout_all() checks for a closed
connection, so the failure needs to take place at that last write.
Thanks to Stefan Sperling for pointing out the problem, complete with
a backtrace and patch. (This commit takes a different approach for a
Turn off auto-clear outside of autocrypt initialization.
The auto-clearing code was added in commit 01bc088c, for autocrypt
initial prompting. It removed having to keep track of every place a
browser or other menu might be displayed and having to remember to
clear it out.
However, clearing when mutt exits is a change of behavior for those
who have turned off alternative screens.
automatic post-release commit for mutt-1.13.2
Revert "Fixes unchecked return from link() in dotlock.c"
This reverts commit 317b7f6b53d8a4272acf8ef1b56f3406e9bc2691.
automatic post-release commit for mutt-1.13.1
Update UPDATING file for 1.13.1 release.
Fix segv in IMAP postponed menu caused by reopen_allow.
imap_open_mailbox() leaves IMAP_REOPEN_ALLOW set for the connection.
I noticed this previously but didn't bother untangling the logic yet
because the index always calls mx_check_mailbox() right away, which
unsets the flag.
However, when debugging the segv for commit 51729d8d I realized the
postponed menu/context also suffers from the problem, leaving the menu
ripe for segvs due to unmanaged expunges.
I believe imap_read_headers() turns it off and back on to avoid
goofing up imap_cmd_finish() when a reopen *is* allowed.
The logic needs to be cleaned up and fixed. However for a stable
branch fix, I'm am taking a conservative approach and just calling
mx_check_mailbox() to turn it back off.
Fix imap postponed mailbox use-after-free error.
mutt_get_postponed() was calling mx_close_mailbox(), but not checking
the return value. Because the postponed context is an actual
read-write, selected mailbox in a new connection, a failed close left
a dangling pointer in connection->idata->ctx.
imap_keepalive() traversed the connection list, finding the Postponed
connection still there, and passed the dangling pointer to
Change an empty postponed mailbox to just call fastclose. Change the
other closes to retry on a postive return code "reopen" event and then
finally just call fastclose.
Outside the index and postponed menu, Mutt's code only uses append or
readonly temporary contexts. Those are guaranteed to call
mx_fastclose_mailbox() and return 0.
Rename sidebar mailbox shortcuts option and default off.
Rename to $sidebar_use_mailbox_shortcuts. The shortening wasn't that
much shorter and made the name confusing.
To prevent complaints in the future as others transition to 1.13,
Make shortpath/indent code guards explicit.
In actuality, the parent_depth and indent_width won't ever be
But the new code for unset $sidebar_relative_shortpath_indent makes
this much less obvious. Better to be explicit than have some small
future code change result in a bug.
Create $sidebar_relative_shortpath_indent, default unset.
When unset this option provides the pre-1.13.0 sidebar indentation and
Setting the option will enable the new (relative to previous entries)
indentation and shortening behavior.
Note the mailbox shortcuts are controlled by
$sidebar_use_mb_shortcuts, which defaults set.
Fix new option order in the manual.
I actually intended to push commit abfaa0e0 to a remote branch, but
accidentally ended up pushing it to stable. :-O
Anyway, I think the option is okay, but may have to tweek it a bit.
This fixes a mistake where it was placed out of order in init.h.
Add $sidebar_use_mb_shortcuts to turn off shortcuts.
If unset, Mutt will revert to pre-1.13 display behavior, matching and
removing a literal $folder prefix, without using mailbox shortcuts.
Minor documentation fixes.
automatic post-release commit for mutt-1.13.0
Set UPDATING file release date for 1.13.0.
Change "Prf Enc" to "Prf Encr".
Make the abbreviation a bit clearer, that it means Encryption instead
Thanks to Morten Bo Johansen for the suggestion.