From a64636173e0d162d0e9e36d40fad32d1bc56898b Mon Sep 17 00:00:00 2001 From: jacqueline Date: Mon, 31 Jul 2023 02:28:45 +0000 Subject: [PATCH] Don't null-terminate already null-terminated strings This was causing issues with genre tags sourced from id3genres (I think all m4a files with genres might be affected?). id3genres is const, so even when the write is a no-op, attempting it caused a segfault --- tags.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tags.c b/tags.c index 6c6b2b5..750d907 100644 --- a/tags.c +++ b/tags.c @@ -46,7 +46,8 @@ tagscallcb(Tagctx *ctx, int type, const char *k, char *s, int offset, int size, e = s + strlen(s); while(e != s && (uchar)e[-1] <= ' ') e--; - *e = 0; + if(*e != 0) + *e = 0; } if(*s){ ctx->tag(ctx, type, k, s, offset, size, f); -- 2.45.2