~aasg/nixexprs

b61c7342d34e8b206c5a2b94712264f2d6c1ccc6 — Aluísio Augusto Silva Gonçalves 2 months ago 029dbcf
pkgs: Run hooks when phases are overriden

https://github.com/jtojnar/nixpkgs-hammering/blob/193d2108495b6c53c591f2f99de981153f218003/explanations/missing-phase-hooks.md
2 files changed, 8 insertions(+), 0 deletions(-)

M pkgs/development/tools/esbuild/default.nix
M pkgs/tools/networking/dyndnsc/default.nix
M pkgs/development/tools/esbuild/default.nix => pkgs/development/tools/esbuild/default.nix +4 -0
@@ 19,7 19,11 @@ buildGoModule rec {
  subPackages = [ "./cmd/esbuild" ];

  checkPhase = ''
    runHook preCheck

    go test ./internal/...

    runHook postCheck
  '';

  meta = with lib; {

M pkgs/tools/networking/dyndnsc/default.nix => pkgs/tools/networking/dyndnsc/default.nix +4 -0
@@ 25,7 25,11 @@ python3Packages.buildPythonApplication rec {

  # Disable tests not supported in the sandbox.
  checkPhase = ''
    runHook preCheck

    py.test -k 'not dnswanip'

    runHook postCheck
  '';
  # Allow tests involving localhost on macOS.
  __darwinAllowLocalNetworking = true;